Repository navigation
Take CUDA 12 PyTorch from the cu128 index in the cu12 training requirements - #101
Merged
Merged
Conversation
…ements pip install -r code/requirements_public_train-cu12.txt against PyPI alone now resolves torch 2.10.0 with cuda-bindings 12.9.4: newer PyPI torch requires cuda-bindings 13.x, which cuquantum-python-cu12 (<13) rejects, so pip backtracks to the last torch that pins a 12.x cuda-bindings. cuda-core 1.3.0 refuses to import with cuda-bindings older than 12.9.8, so the cuStabilizer backend fails with ImportError. This breaks the README install and the mid-gpu-tests, multi-gpu-tests and gpu-coverage CI jobs. Declare the cu128 PyTorch index in the requirements file. The same file then resolves torch 2.11.0+cu128 with cuda-bindings 12.9.10, the set the gpu-tests matrix already runs. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Ivan Basov <ibasov@nvidia.com>
ivanbasov
marked this pull request as ready for review
November 16, 2026 20:59
Member
Author
|
@anjbur could you take a look as well? The functional change is the single |
bmhowe23
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip install -r code/requirements_public_train-cu12.txtagainst PyPI alone now produces an environment where the cuStabilizer backend cannot be imported:This is the README training install, and it is what
mid-gpu-tests,multi-gpu-testsandgpu-coveragerun. All three fail on currentmain(manual run); thegpu-testsmatrix passes because it installs through the cu128 PyTorch index.Cause
torch2.11 and later requirecuda-bindings13.x;cuquantum-python-cu12requires<13. pip backtracks totorch 2.10.0, which pinscuda-bindings==12.9.4.cuda-core 1.3.0(PyPI, 2026-11-11) refuses to import withcuda-bindingsolder than 12.9.8. Before that release the same resolution worked.Change
code/requirements_public_train-cu12.txtdeclares--extra-index-url https://download.pytorch.org/whl/cu128.No workflow changes: the three jobs keep their plain
pip install -r, so they test the same command users run.Verification
pip install --dry-run --reportin fresh venvs:main--index-url .../cu121(Dockerfile default)The resolved set is the one the
gpu-testscu128 matrix already runs green.gpu-coverageruns on this PR with the plainpip install -rand is the end-to-end check of the fix.mid-gpu-testsandmulti-gpu-testsrun only onmain, so they are confirmed by the push run after merge. The dry-run checks resolution only; no local install or GPU run was done.Notes
cuda-bindings>=12.9.8,<13lower bound without the index, resolves totorch 2.9.1from PyPI. Not taken: it silently moves users to an older torch than the one CI tests.mainthat case already resolves to PyPItorch 2.10.0, so the cu121 build was not being selected before either.🤖 Generated with Claude Code